Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlap on main nav and hero #11898

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix overlap on main nav and hero #11898

merged 1 commit into from
Nov 1, 2024

Conversation

yonikid15
Copy link
Contributor

👋 Introduction

  • Just made a quick fix I saw where the main nav overlaps the main content when loading

🕵️ Details

🧪 Testing

  1. Login as admin@test.com
  2. Go to skills editor page and select a skill
  3. Click edit the information and ensure the main nav doesn't overlap when loading

📸 Screenshot

Before:
image

After:
image

petertgiles
petertgiles approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how this works. 😅 But it does work.

@yonikid15 yonikid15 added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 16c8153 Nov 1, 2024
12 checks passed
@yonikid15 yonikid15 deleted the fix-main-site-nav-overlap branch November 1, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertgiles petertgiles petertgiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonikid15 @petertgiles